Fix regex to fit for non-recursive make. #93

lyonlh · 2019-12-07T12:14:58Z

Fix the issue #90

i-ky · 2022-03-07T14:36:43Z

compiledb/parser.py

+make_enter_dir = re.compile(r"^\s*make(?:\[\d+\])*: Entering directory [`\'\"](?P<dir>.*)[`\'\"]\s*$")
+make_leave_dir = re.compile(r"^\s*make(?:\[\d+\])*: Leaving directory .*$")


I would suggest to allow at most one bracket pair:

Suggested change

make_enter_dir = re.compile(r"^\s*make(?:\[\d+\])*: Entering directory [`\'\"](?P<dir>.*)[`\'\"]\s*$")

make_leave_dir = re.compile(r"^\s*make(?:\[\d+\])*: Leaving directory .*$")

make_enter_dir = re.compile(r"^\s*make(?:\[\d+\])?: Entering directory [`\'\"](?P<dir>.*)[`\'\"]\s*$")

make_leave_dir = re.compile(r"^\s*make(?:\[\d+\])?: Leaving directory .*$")

i-ky · 2022-06-29T14:05:50Z

@nickdiego, could you please merge and release this fix, please?

Fix regex to fit for non-recursive make.

4dae97d

i-ky reviewed Mar 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix regex to fit for non-recursive make. #93

Fix regex to fit for non-recursive make. #93

lyonlh commented Dec 7, 2019

i-ky Mar 7, 2022

i-ky commented Jun 29, 2022

		make_enter_dir = re.compile(r"^\smake(?:\[\d+\]): Entering directory [`\'\"](?P<dir>.)[`\'\"]\s$")
		make_leave_dir = re.compile(r"^\smake(?:\[\d+\]): Leaving directory .*$")

Fix regex to fit for non-recursive make. #93

Are you sure you want to change the base?

Fix regex to fit for non-recursive make. #93

Conversation

lyonlh commented Dec 7, 2019

i-ky Mar 7, 2022

Choose a reason for hiding this comment

i-ky commented Jun 29, 2022