Fix crash on warning of hidden declaration. Issue #1038 #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see #1038 (comment) for reference |
|
|
NikLeberg
force-pushed
the
fuzz_12dc86d
branch
from
57fb8b9
to
b78ecbf
Compare
nickg
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzzing done by @avelure produced various interesting errors.
The one I try to fix here seems to stem from a simple typo in the implementation of
warn_hidden_decl.I added a testcase but it produces another error
../test/test_util.c:199:F:Core:test_issue1038:0: Assertion 'parse() == NULL' failedBut I don't know exactly why. I do not fully understand the test framework though and could be doing something stupid.Cheers