Add parsing of transformer impedance corrections #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we do have example data for this
Since both have the same pattern of the last N columns being optional and defaulting to zero when not present.
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 92.14% 92.26% +0.12%
==========================================
Files 3 3
Lines 191 194 +3
==========================================
+ Hits 176 179 +3
Misses 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/testfiles/synthetic_data_v30.raw, contra what i said in Add VSC DC Lines and Switch Shunts #34)sizehintfor SwitchedShunts that i forgot to add in Add VSC DC Lines and Switch Shunts #34 (see Review/improve sizehints #37 / Alternative to counting rows and pre-allocating columns? Compare usingpush!? #5)