Handle deprecation of pkg_resources and favor importlib #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, manually installing @nickstenning as this is going to slowly start becoming more of an issue - any chance of a release? 🙂 |
Comment on lines
+35
to
+44
| try: | ||
| from pkg_resources import iter_entry_points # Python 3.7-3.9 | ||
|
|
||
| export_choices = dict((_export.name, _export) | ||
| for _export in iter_entry_points('honcho_exporters')) | ||
| except ImportError: | ||
| from importlib.metadata import entry_points # Python 3.10+ | ||
|
|
||
| export_choices = dict((_export.name, _export) | ||
| for _export in entry_points(group='honcho_exporters')) |
There was a problem hiding this comment.
this should really be flipped -- prefer importlib.metadata and if it's not available then fall back to (deprecated) pkg_resources -- otherwise this will still trigger deprecation warnings even on systems where importlib.metadata would avoid such warnings
|
Thank you for this! I've fixed this in #249 and will cut a release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the Python 3.10 images on CircleCI no longer include
pkg_resroucesas it's deprecated:Starting in Python 3.8, importlib.metdata is the preferred way to find entry points.