Multi-process proof-of-concept, fix #68 (WIP) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves bins into standard `src/bin` folder - Adds a basic test (TODO: doesn't work on gh-actions CI) - Reformat with new `rustfmt.toml`, rearrange some code, add some comments - Fix wrong error message for `GetVersionExA` - `cargo update`
yay unsoundness: thread '<unnamed>' panicked at core\src\panicking.rs:221:5: unsafe precondition(s) violated: slice::get_unchecked requires that the index is within the slice note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace thread caused non-unwinding panic. aborting. error: test failed, to rerun pass `--test basic` Caused by: process didn't exit successfully: `D:\Projects\blondie\target\debug\deps\basic-10e35b968cd5dbed.exe` (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN)
MingweiSamuel
commented
Aug 21, 2024
src/lib.rs
Outdated
Comment on lines
277
to
285
| // let kernel_logger_name_with_nul_pcstr = PCSTR(kernel_logger_name_with_nul.as_ptr()); | ||
| // Stop an existing session with the kernel logger, if it exists | ||
| // We use a copy of `event_trace_props` since ControlTrace overwrites it | ||
| { | ||
| let mut event_trace_props_copy = event_trace_props.clone(); | ||
| let control_stop_retcode = ControlTraceA( | ||
| None, | ||
| kernel_logger_name_with_nul_pcstr, | ||
| addr_of_mut!(event_trace_props_copy) as *mut _, | ||
| EVENT_TRACE_CONTROL_STOP, | ||
| ); | ||
| let mut event_trace_props_copy = (*event_trace_props).clone(); | ||
| // SAFETY: controlled input. | ||
| // https://learn.microsoft.com/en-us/windows/win32/api/evntrace/nf-evntrace-controltracea | ||
| let control_stop_retcode = unsafe { | ||
| ControlTraceA( | ||
| None, | ||
| KERNEL_LOGGER_NAMEA, |
There was a problem hiding this comment.
Wondering what the difference between kernel_logger_name_with_nul_pcstr and KERNEL_LOGGER_NAMEA is
MingweiSamuel
commented
Aug 21, 2024
| @@ -195,17 +274,19 @@ unsafe fn trace_from_process_id( | |||
| .s | |||
| .copy_from_slice(&kernel_logger_name_with_nul[..]); | |||
|
|
|||
| let kernel_logger_name_with_nul_pcstr = PCSTR(kernel_logger_name_with_nul.as_ptr()); | |||
| // let kernel_logger_name_with_nul_pcstr = PCSTR(kernel_logger_name_with_nul.as_ptr()); | |||
| // Stop an existing session with the kernel logger, if it exists | |||
There was a problem hiding this comment.
I wonder if this can cause UB if blondie is running in multiple processes...
There was a problem hiding this comment.
Right now it seems to cause
value: Other(WIN32_ERROR(4201), "The instance name passed was not recognized as valid by a WMI data provider.\r\n", "TraceSetInformation stackwalk")
|
My knowledge of windows APIs and unsafe rust is insufficient to complete this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69
has a bug rn (I haven't tried unsafe rust before) :( happens once in a while only