Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages + update pydantic to v2 #103

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
change euler time in exp design + add support for project specific ma…
…ke commands
  • Loading branch information
nicolas-kuechler committed Oct 17, 2024
commit d562e9fd624ae0dbd2ecebf6ecac31a04f208494
19 changes: 18 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -51,6 +51,7 @@ endif

# on `make` and `make help` list all targets with information
help:
@$(MAKE) --ignore-errors --no-print-directory -C $(does_config_dir) help-custom 2> /dev/null || true
@echo 'Running Experiments'
@echo ' make run suite=<SUITE> id=new - run the experiments in the suite'
@echo ' make run suite=<SUITE> id=<ID> - continue with the experiments in the suite with <ID> (often id=last)'
@@ -385,4 +386,20 @@ docs-build: install
poetry run make html -C ../docs

docs: docs-build
@open docs/build/html/index.html
@open docs/build/html/index.html



#################################
# ___ _ _ ___ _____ ___ __ __
# / __| | | / __|_ _/ _ \| \/ |
# | (__| |_| \__ \ | || (_) | |\/| |
# \___|\___/|___/ |_| \___/|_| |_|
#
#################################

# include the targets of a project specific make file
include_file=$(does_config_dir)/Makefile
ifneq ("$(wildcard $(include_file))","")
include $(include_file)
endif
3 changes: 2 additions & 1 deletion src/roles/suite-scheduler-enqueue/tasks/slurm.yml
Original file line number Diff line number Diff line change
@@ -36,7 +36,8 @@
if euler_gpu_model is none
else
'--gpus=' + euler_gpu_model + ':' + euler_gpu_number | string }}
cpu_cmd: --time={{ euler_job_minutes }} -n {{ euler_cpu_cores }} --mem-per-cpu={{ euler_cpu_mem_per_core_mb }}
cpu_cmd: --time={{ job.exp_run_config.get('$euler_job_minutes$', euler_job_minutes) }} -n {{ euler_cpu_cores }} --mem-per-cpu={{ euler_cpu_mem_per_core_mb }}
# TODO [nku] could also support custom number of cpu cores and memory but this would be a bit against the idea of host types
register: sbatch_output
shell: |
source /etc/profile