Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement private lan module #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Implement private lan module #32

wants to merge 6 commits into from

Conversation

yuhei159
Copy link
Contributor

@yuhei159 yuhei159 commented Jul 19, 2017 •
edited
Loading

SUMMARY
  1. describe private lans (NiftyDescribePrivateLans)
    • get unique private lan
  2. create private lan (NiftyCreatePrivateLan) if target private lan does not exist
    • private_lan_name
    • cidr_block
    • description
    • availability_zone
    • accounting_type
  3. modify private lan (NiftyModifyPrivateLanAttribute)
    • private_lan_name
    • cidr_block
    • description
    • accounting_type
  4. delete private lan (NiftyDeletePrivateLan)
    • delete private lan if setted state is absent
RELATED ISSUE
COVERRAGE
Name                        Stmts   Miss  Cover
-----------------------------------------------
niftycloud.py                 171     31    82%
niftycloud_fw.py              319      5    98%
niftycloud_lb.py              125     21    83%
niftycloud_private_lan.py     259      0   100%
niftycloud_volume.py          105     25    76%
-----------------------------------------------
TOTAL                         979     82    92%

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 92.724% when pulling 9c8bb78 on yuhei159:feature/add_private_lan into 4a9be52 on NIFTYCloud:master.

@yuhei159 yuhei159 force-pushed the feature/add_private_lan branch from 9c8bb78 to ea5acb2 Compare July 19, 2017 03:03
@yuhei159 yuhei159 changed the title [WIP] Add Private Lan module Add Private Lan module Jul 19, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 95.381% when pulling ea5acb2 on yuhei159:feature/add_private_lan into 4a9be52 on NIFTYCloud:master.

@yuhei159 yuhei159 changed the title Add Private Lan module implement private Lan module Jul 20, 2017
Blufe
Blufe approved these changes Jul 25, 2017
View reviewed changes
library/niftycloud_lan.py Outdated
private_lan_set = None

params = dict()
params['PrivateLanName.1'] = module.params['private_lan_name']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describe_private_lans() should request network_id or private_lan_name.
Also, network_id should take precedence over private_lan_name.

This is necessary to achieve the following.

  • Fix mistakes in logic that can not change private_lan_name
  • Flexible request for describe_private_lans()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review.
If network_id setted then Ｉ modified the network_id to take precedence over private_lan_name.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.07%) to 95.341% when pulling d71e412 on yuhei159:feature/add_private_lan into 4a9be52 on NIFTYCloud:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.07%) to 95.341% when pulling 0d4fc53 on yuhei159:feature/add_private_lan into 4a9be52 on NIFTYCloud:master.

@yuhei159 yuhei159 force-pushed the feature/add_private_lan branch from 0d4fc53 to cdcdf05 Compare July 26, 2017 01:57
@coveralls
Copy link

Coverage Status

Coverage increased (+1.07%) to 95.341% when pulling cdcdf05 on yuhei159:feature/add_private_lan into bc78800 on NIFTYCloud:master.

@yuhei159 yuhei159 changed the title implement private Lan module Implement private lan module Jul 26, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.07%) to 95.341% when pulling f957e21 on yuhei159:feature/add_private_lan into bc78800 on NIFTYCloud:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.08%) to 95.347% when pulling 71e1561 on yuhei159:feature/add_private_lan into bc78800 on NIFTYCloud:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blufe Blufe Blufe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuhei159 @coveralls @Blufe