Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support nifcloud_volume 4000 size #148

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

fuku2014
Copy link
Member

@fuku2014 fuku2014 commented Dec 9, 2024

Description

How Has This Been Tested?

  • Buld with make install command.
make install
  • Apply this example.
terraform {
  required_providers {
    nifcloud = {
      source = "nifcloud/nifcloud"
    }
  }
}

provider "nifcloud" {
  region = "jp-east-1"
}

resource "nifcloud_volume" "basic" {
  size = 4000
  volume_id = "example"
  disk_type = "High-Speed Storage B"
  instance_id = "your instance id"
}
  • Run acceptance tests.
TF_ACC=1 go test ./nifcloud/acc/... -v -count 1 -parallel 1 -timeout 360m -run TestAcc_Volume
  • Enjoy!!😸

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

@fuku2014 fuku2014 requested a review from o108minmin December 16, 2024 08:05
@o108minmin o108minmin merged commit 8f11219 into main Dec 20, 2024
2 checks passed
@o108minmin
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants