BSLagBoneController support #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HENDRIX-ZT2
reviewed
Jul 1, 2022
Candoran2
reviewed
Nov 17, 2022
| n_controller.frequency = 1.0 | ||
| n_controller.phase = 0.0 | ||
| n_controller.start_time = consts.FLOAT_MIN |
There was a problem hiding this comment.
Are you sure these two aren't reversed? Both in the xml and the (admittedly single) BSLagBoneController I checked start_time is FLOAT_MAX and stop_time is FLOAT_MIN.
Candoran2
reviewed
Nov 3, 2023
| #BSLagBoneControllers are only for skyrim and later, afaik | ||
| game = bpy.context.scene.niftools_scene.game | ||
| if game not in ('SKYRIM'): |
There was a problem hiding this comment.
This could now be changed to if not bpy.context.scene.niftools_scene.is_skyrim():
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/blender-niftools-addon-reviewer
Overview
[Overview of the content of the pull request]
BSLagBoneControllers are available in the nifformat but not exposed, this is a simple setup to allow for import and export.
Detailed Description
[List of functional updates]
The implementation is entirely custom property driven on niftools bone properties, it doesn't cause any actual behavior on the blender side. The behavior of lagbones would be quite similar to 'wiggle' or 'jiggly' bones in blender but those are addons, afaik similar functionality doesn't exist in base blender...
Fixes Known Issues
[Ordered list of issues fixed by this PR]
None, new feature
Documentation
[Overview of updates to documentation]
I should add some, if you think this PR has some merit.
Afaik lagbones are Skyrim only and in LE they work for skeletons and skins, whereas in SSE its skeleton only (caveat; I think this is the case, might be off)
Testing
[Overview of testing required to ensure functionality is correctly implemented]
Import/export nif with bslagbones set.
Manual
[Set of steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]
I've not set up properties for everything, just the ones I think are meaningful, should I?
Should this be refactored/ placed somewhere else?