Fixed minor ui-isses in guide section #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothuman2718
force-pushed
the
guide-fixes
branch
from
3f8fccd
to
21c6bc0
Compare
beatfactor
reviewed
Apr 4, 2024
| @@ -64,7 +64,7 @@ GeckoDriver can also be used as a standalone application. Usage steps are docume | |||
| <br><br> | |||
| ### Command line usage | |||
|
|
|||
| <pre><code>$ ./bin/geckodriver-0.23 -help | |||
| <pre class="line-numbers"><code>$ ./bin/geckodriver-0.23 -help | |||
There was a problem hiding this comment.
we don't need line number on these type of containers, only on actual source code.
There was a problem hiding this comment.
If we are not giving ''line-numbers'', It will get ''code-space'' class due to which the above issue is coming
I thought this might introduce new bugs, So I just gave "line-numbers" class, If needed I will work on this and modify the updatePre function in app-esm.js
There was a problem hiding this comment.
Try and remove the code-space class as well.
|
@beatfactor Please have a look. Added a new class |
sorry for the delay here, I was away last week. I'll try to get this merged soon, thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed minor UI issues in the guide section like
While fixing these bugs, I found that a lot of data in docs is repeated, and extensive refactoring is possible.
I will fix this is next PR.