Define WIN32_LEAN_AND_MEAN to build the zip library on Windows

[scribam]

There are other files where windows.h is included but WIN32_LEAN_AND_MEAN is not defined. With this PR, WIN32_LEAN_AND_MEAN is defined consistently across the project

[dillof]

Why did you remove NOCRYPT? Are you sure that does not influence <windows.h> or <bcrypt.h>?

[scribam]

From C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\Windows.h:

#ifndef WIN32_LEAN_AND_MEAN
#include <cderr.h>
#include <dde.h>
#include <ddeml.h>
#include <dlgs.h>
#ifndef _MAC
#include <lzexpand.h>
#include <mmsystem.h>
#include <nb30.h>
#include <rpc.h>
#endif
#include <shellapi.h>
#ifndef _MAC
#include <winperf.h>
#include <winsock.h>
#endif
#ifndef NOCRYPT
#include <wincrypt.h>
#include <winefs.h>
#include <winscard.h>
#endif

#ifndef NOGDI
#ifndef _MAC
#include <winspool.h>
#ifdef INC_OLE1
#include <ole.h>
#else
#include <ole2.h>
#endif /* !INC_OLE1 */
#endif /* !MAC */
#include <commdlg.h>
#endif /* !NOGDI */
#endif /* WIN32_LEAN_AND_MEAN */

We do not need to define NOCRYPT because it is inside the #ifndef WIN32_LEAN_AND_MEAN block.

Also from https://github.com/v8/v8/blob/main/src/base/win32-headers.h#L15:

// WIN32_LEAN_AND_MEAN implies NOCRYPT and NOGDI.

[dillof]

Thanks for the explanation, makes sense.

[0-wiz-0]

Thanks, merged.