Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix appveyor build #442

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Attempt to fix appveyor build #442

merged 1 commit into from
Jul 17, 2024

Conversation

scribam
Copy link
Contributor

@scribam scribam commented Jul 17, 2024

No description provided.

@0-wiz-0
Copy link
Member

0-wiz-0 commented Jul 17, 2024

Thank you for looking at fixing the appveyor build!
The proposed patch is incorrect though. As you can see in https://ci.appveyor.com/project/nih-at/libzip/builds/50232046/job/oq2p1n7arprtib7y zlib, liblzma and zstd are not found by the build. (Which is the whole point of using vcpkg, to provide these dependencies.)

@0-wiz-0 0-wiz-0 closed this Jul 17, 2024
@scribam
Copy link
Contributor Author

scribam commented Jul 17, 2024

@0-wiz-0 Are you sure this is incorrect?
When I look at the CMake configure step from your link, I can read:

-- Found ZLIB: optimized;C:/projects/libzip/build/vcpkg_installed/x64-windows/lib/zlib.lib;debug;C:/projects/libzip/build/vcpkg_installed/x64-windows/debug/lib/zlibd.lib (found suitable version "1.3.1", minimum required is "1.1.2")
-- Found BZip2: optimized;C:/projects/libzip/build/vcpkg_installed/x64-windows/lib/bz2.lib;debug;C:/projects/libzip/build/vcpkg_installed/x64-windows/debug/lib/bz2d.lib (found version "1.0.8")
[...]
-- Found LibLZMA: optimized;C:/projects/libzip/build/vcpkg_installed/x64-windows/lib/lzma.lib;debug;C:/projects/libzip/build/vcpkg_installed/x64-windows/debug/lib/lzma.lib (found suitable version "5.4.4", minimum required is "5.2")
[...]
-- Found zstd: C:/projects/libzip/build/vcpkg_installed/x64-windows/debug/lib/zstd.lib (Required is at least version "1.3.6")

Also, these files are included in the compilation process:

  • zip_algorithm_bzip2.c
  • zip_algorithm_xz.c
  • zip_algorithm_zstd.c

@0-wiz-0
Copy link
Member

0-wiz-0 commented Jul 17, 2024

Ok, that is weird. Perhaps I misinterpreted something.

However, can you please explain how vcpkg knows to install these three packages after your patch?

@0-wiz-0 0-wiz-0 reopened this Jul 17, 2024
@scribam
Copy link
Contributor Author

scribam commented Jul 17, 2024

With this file https://github.com/nih-at/libzip/blob/main/vcpkg.json

Manifest mode uses declarative JSON files to describe metadata about your project or package. In any case, the name of this file is vcpkg.json.

Manifest mode is engaged by running the vcpkg install command while there's a manifest file (vcpkg.json) in the working directory.

Source: https://learn.microsoft.com/en-us/vcpkg/concepts/manifest-mode

@0-wiz-0 0-wiz-0 added the feedback Waiting for feedback from submitter. label Jul 17, 2024
@0-wiz-0 0-wiz-0 merged commit 5f55ecd into nih-at:main Jul 17, 2024
2 of 3 checks passed
@0-wiz-0
Copy link
Member

0-wiz-0 commented Jul 17, 2024

Thanks!

@0-wiz-0 0-wiz-0 removed the feedback Waiting for feedback from submitter. label Jul 17, 2024
@scribam scribam deleted the appveyor branch July 17, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants