Merge pull request #199 from Tehsurfer/monthly-stats-fix

Fix a dictionary evaluation error in monthly stats
nih-sparc · Mar 5, 2024 · 258b8b4 · 258b8b4
2 parents 9ab8100 + 659d151
commit 258b8b4
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/scripts/monthly_stats.py b/scripts/monthly_stats.py
@@ -149,12 +149,14 @@ def create_user_download_object(self, dataset_details_object, download_stats):
             for contributor in dataset['contributors']:
                 orcid_id = contributor['orcid']
 
-                # Add the download info with an orcid id as a key
-                if orcid_id not in users.keys():
-                    users[orcid_id] = {}
-                    users[orcid_id]['datasets'] = downloadInfo
-                else:
-                    users[orcid_id]['datasets'] += downloadInfo
+                if orcid_id is not None:
+                    # Add the download info with an orcid id as a key
+                    if orcid_id not in users.keys():
+                        users[orcid_id] = {}
+                        users[orcid_id]['datasets'] = downloadInfo
+                    else:
+                        # Must to a dictionary 'get' below, as using += mutates the dictionary
+                        users[orcid_id]['datasets'] = users.get(orcid_id)['datasets'] + downloadInfo
 
         return users