Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding launch link for Biolucida viewer #50

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Adding launch link for Biolucida viewer #50

wants to merge 5 commits into from

Conversation

hsorby
Copy link
Contributor

@hsorby hsorby commented Aug 24, 2021

Description

Adding an endpoint for retrieving a blv link from the biolucida server.

Type of change

Delete those that don't apply.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added a test to check for success and failure of new endpoint.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests that prove my fix is effective or that my feature works

@hsorby hsorby requested review from Tehsurfer and alan-wu August 25, 2021 00:07
@nickerso nickerso marked this pull request as draft August 25, 2021 03:33
Tehsurfer
Tehsurfer approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@Tehsurfer Tehsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsurfer Tehsurfer Tehsurfer approved these changes

@alan-wu alan-wu alan-wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsorby @alan-wu @Tehsurfer