Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e testing #104

Merged
merged 14 commits into from
May 15, 2024
Merged

Fix e2e testing #104

merged 14 commits into from
May 15, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

This PR focuses on

  1. Fix some of the e2e testing caused by the About page refactor
  2. Update GitHub action setting for scheduled cypress testing

@cypress Cypress
Copy link

cypress bot commented May 14, 2024 •
edited
Loading

Passing run #19 ↗︎

0 76 1 0 Flakiness 0

Details:

remove homepage cy.intercept
Project: SPARC Vue3 Portal Testing Commit: 01abd212b4
Status: Passed Duration: 09:32 💡
Started: May 15, 2024 2:34 AM Ended: May 15, 2024 2:43 AM

Review all test suite changes for PR #104 ↗︎

@ddjnw1yu ddjnw1yu marked this pull request as draft May 15, 2024 00:12
@ddjnw1yu ddjnw1yu marked this pull request as ready for review May 15, 2024 02:45
alan-wu
alan-wu approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@alan-wu alan-wu merged commit f7861f7 into nih-sparc:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-wu alan-wu alan-wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddjnw1yu @alan-wu