Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blvlink request #172

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add blvlink request #172

merged 2 commits into from
Aug 6, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

@ddjnw1yu ddjnw1yu commented Aug 5, 2024

This PR is for the wrike ticket - 3D Button across Image Viewers not Behaving as Expected

The blv link does not exist in the response from the imagemap/sharelink endpoint request.

It may be because the response structure has changed sometime in the past or has never had the BLV link. Moved the blv link request from the ViewerMetadata component to the Viewer component.

It will now show the following page after clicking the button.

Screenshot 2024-08-06 at 9 38 24 AM

Copy link

cypress bot commented Aug 5, 2024



Test summary

71 0 2 0


Run details

Project SPARC Vue3 Portal Testing
Status Passed
Commit b9a332c
Started Aug 5, 2024 10:11 PM
Ended Aug 5, 2024 10:25 PM
Duration 13:44 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alan-wu alan-wu merged commit 06db98c into nih-sparc:main Aug 6, 2024
2 checks passed
@ddjnw1yu ddjnw1yu deleted the view-in-3d-button branch August 6, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants