Add inner try-catch to catch biolucida request issue separately #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPARC Vue3 Portal Testing
|
||||||||||||||||||||||||||||
| Project |
SPARC Vue3 Portal Testing
|
| Branch Review |
gallery-testing-issue
|
| Run status |
|
| Run duration | 13m 52s |
| Commit |
|
| Committer | David J. Yu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
71
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the image gallery testing issue caused by failed biolucida requests.
Previously, one
try-catchwas used for both scrunch and biolucida requests. If one fails, another one will be affected. This is causing no items in the gallery.Added the inner
try-catchfor biolucida request. Scicrunch-based functionality will not be affected (e.g. dataset info/UI display) if the biolucida request failed.Gallery testing will not be affected by the biolucida server issue as long as the scicrunch server works fine.