Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes with update to mapviewer 1.4.1. #194

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Sep 3, 2024

Bug fixes on map-viewer, including:

Fix an issue with help mode on flatmap.
Fix and issue with hover over species on flatmap.
Improve marker text on scaffold.

This can be tested on https://alan-wu-sparc-app.herokuapp.com/apps/maps?type=ac

@alan-wu alan-wu requested review from ddjnw1yu and akhuoa September 3, 2024 00:39
Copy link
Collaborator

@akhuoa akhuoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified.

Copy link

cypress bot commented Sep 3, 2024

SPARC Vue3 Portal Testing    Run #240

Run Properties:  status check passed Passed #240  •  git commit d299520eff: Update to mapviewer 1.4.1.
Project SPARC Vue3 Portal Testing
Branch Review map-viewer-1.4.1
Run status status check passed Passed #240
Run duration 14m 13s
Commit git commit d299520eff: Update to mapviewer 1.4.1.
Committer alan-wu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 71
View all changes introduced in this branch ↗︎

@alan-wu alan-wu merged commit 6d80d1d into nih-sparc:main Sep 3, 2024
2 checks passed
@alan-wu alan-wu deleted the map-viewer-1.4.1 branch November 14, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants