re-order components and address components loading at different point #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPARC Vue3 Portal Testing
|
||||||||||||||||||||||||||||||||||
| Project |
SPARC Vue3 Portal Testing
|
| Branch Review |
re-order-homepage-components
|
| Run status |
|
| Run duration | 15m 01s |
| Commit |
|
| Committer | Eric Gauzens |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
71
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/e2e/homepage.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Homepage > SPARC by the numbers |
Test Replay
Screenshots
|
|
|
The latest test failure is not to do with the changes, but rather the fact that the metrics have not been published. I have notified dat-core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this ticket: https://www.wrike.com/open.htm?id=1504551274
And seeing about loading the entire homepage via SSR instead of having some rendered on the client. If i recall we had issues with this on deployment before eventhough it works fine locally but I am trying it out on staging again