Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local portal issue launched by yarn dev #215

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

The yarn dev command brings up a forever-loading page. It is caused by some unexpected yarn.lock file line changes in commit 3ae9a962df63a3569fe6389bbf3a40cda5828230.

Screenshot 2024-10-11 at 9 23 58 AM

The issue is currently also affecting the local Cypress testing. Therefore, this PR is created to revert related commits and update the yarn.lock file with the required dependencies.

Require the removal of old node_modules for testing.

Copy link

cypress bot commented Oct 10, 2024

SPARC Vue3 Portal Testing    Run #294

Run Properties:  status check passed Passed #294  •  git commit 20c5a0c377: Merge branch 'main' into fix-dev-issue
Project SPARC Vue3 Portal Testing
Run status status check passed Passed #294
Run duration 15m 00s
Commit git commit 20c5a0c377: Merge branch 'main' into fix-dev-issue
Committer David J. Yu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 72

@ddjnw1yu ddjnw1yu requested review from alan-wu and egauzens October 10, 2024 21:02
@egauzens egauzens merged commit 2c296a1 into nih-sparc:main Oct 10, 2024
2 checks passed
@ddjnw1yu ddjnw1yu deleted the fix-dev-issue branch October 10, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants