Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata file location navigation #216

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

This is to fix a further issue after the commit b7bca4af4f037631b7af457997d0476a3ed43b94.

The file name in Pennsieve does not match the name in the path stored in Scicrunch. Therefore, the file location navigation does not work as expected.

Click the file location in the following two links to see the difference (dataset 230 segmentation viewer).

@ddjnw1yu ddjnw1yu requested a review from alan-wu October 13, 2024 21:16
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the navigation works with the fix.

Copy link

cypress bot commented Oct 13, 2024

SPARC Vue3 Portal Testing    Run #295

Run Properties:  status check passed Passed #295  •  git commit fdb2f116fa: Update file.name as well
Project SPARC Vue3 Portal Testing
Run status status check passed Passed #295
Run duration 14m 31s
Commit git commit fdb2f116fa: Update file.name as well
Committer David J. Yu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 72

@alan-wu alan-wu merged commit ba645af into nih-sparc:main Oct 13, 2024
2 checks passed
@ddjnw1yu ddjnw1yu deleted the fix-metadata-file-navigation branch October 13, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants