Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency with biolucida images #230

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Nov 13, 2024

Some issue with biolucida images should now be resolved with this pull request by reducing number of calls to different biolucida server endpoints which can provide inconsistent data. This pull request also simplifies the gallery logic on biolucida images.

Ticket: https://www.wrike.com/open.htm?id=1505618603

Here is a list of some images that will be fixed by this pull request:

Broken: https://sparc.science/datasets/file/387/1?path=files/derivative/sub-292/sam-M292/WGA%20ChAT%20pC2b%20mu%20capi%20M292%2020X1.5Z%20220803_220920_37.jpx
Fixed: https://alan-wu-sparc-app.herokuapp.com/datasets/file/387/1?path=files/derivative/sub-292/sam-M292/WGA%20ChAT%20pC2b%20mu%20capi%20M292%2020X1.5Z%20220803_220920_37.jpx

Broken: https://sparc.science/datasets/file/390/1?path=files/derivative/sam-20201215-RAA/20201215_DH09292020_RAA_488autofl_Cy3PGP_647TH_5x_2020_12_15__17_03_48-001.jpx
Fixed: https://alan-wu-sparc-app.herokuapp.com/datasets/file/390/1?path=files/derivative/sam-20201215-RAA/20201215_DH09292020_RAA_488autofl_Cy3PGP_647TH_5x_2020_12_15__17_03_48-001.jpx

Broken: https://sparc.science/datasets/file/399/1?path=files/derivative/sub-01/sam-03/sam-03_S1.jp2
Fixed: https://alan-wu-sparc-app.herokuapp.com/datasets/file/399/1?path=files/derivative/sub-01/sam-03/sam-03_S1.jp2

Broken: https://sparc.science/datasets/file/402/1?path=files/derivative/sub-01/sam-01/sam-01_Converted.jpx
Fixed: https://alan-wu-sparc-app.herokuapp.com/datasets/file/402/1?path=files/derivative/sub-01/sam-01/sam-01_Converted.jpx

@alan-wu alan-wu requested a review from ddjnw1yu November 13, 2024 01:23
Copy link

cypress bot commented Nov 13, 2024

SPARC Vue3 Portal Testing    Run #324

Run Properties:  status check passed Passed #324  •  git commit 3abdea61ff: Improve codes for checking the availability of biolucida viewer.
Project SPARC Vue3 Portal Testing
Branch Review biolucida-image
Run status status check passed Passed #324
Run duration 14m 46s
Commit git commit 3abdea61ff: Improve codes for checking the availability of biolucida viewer.
Committer alan-wu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 72
View all changes introduced in this branch ↗︎

@ddjnw1yu
Copy link
Collaborator

SPARC Vue3 Portal Testing    Run #323

Run Properties:  <img alt="status check failed" width="10" height="10" src="https://camo.githubusercontent.com/ce191f2ed15e540ea28844862a5b05965953f7fda5ae04d3aa5ec730899a106e/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6661696c65642e737667"> Failed [#323](https://cloud.cypress.io/projects/96rtme/runs/323/overview?utm_source=github&utm_medium=failed&utm_campaign=run%20number)  •  <img alt="git commit" width="10" height="10" src="https://camo.githubusercontent.com/0a4d777bd84d33143a9bd3359a9a5b9817b5b1201ffe6da7c3accaa1a0bc88de/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6769742d636f6d6d69742e737667"> [3abdea61ff](https://github.com/nih-sparc/sparc-app-2/commit/3abdea61ffe02e95c494810e8176009d022683ec): Improve codes for checking the availability of biolucida viewer.
Test results
Tests that failed  Failures **1**
Tests that were flaky  Flaky **0**
Tests that did not run due to a developer annotating a test with .skip  Pending **1**
Tests that did not run due to a failure in a mocha hook  Skipped **0**
Tests that passed  Passing **71**
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/mapsviewer.cy.js • 1 failed test

Seems to be a random fail caused by 3d human body scaffold loading.

@alan-wu alan-wu merged commit 473ffab into nih-sparc:main Nov 13, 2024
2 checks passed
@alan-wu alan-wu deleted the biolucida-image branch December 10, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants