Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error popup on the default apps/maps page. #234

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Remove error popup on the default apps/maps page. #234

merged 1 commit into from
Nov 21, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Nov 20, 2024

Remove failure message on https://sparc.science/apps/maps.

@alan-wu alan-wu requested a review from ddjnw1yu November 20, 2024 23:59
@cypress Cypress
Copy link

cypress bot commented Nov 21, 2024 •
edited
Loading

SPARC Vue3 Portal Testing    Run #339

Run Properties:  status check failed Failed #339  •  git commit 3bfe602ccf: Merge pull request #234 from alan-wu/remove-fail-message
Project SPARC Vue3 Portal Testing
Branch Review main
Run status status check failed Failed #339
Run duration 02m 11s
Commit git commit 3bfe602ccf: Merge pull request #234 from alan-wu/remove-fail-message
Committer Alan Wu
View all properties for this run ↗︎
Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 22
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 166
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/datasets/imagegallery.cy.js • 11 failed tests

View Output

Test Artifacts
Dataset 385 > Gallery Item Test Replay Screenshots
Dataset 385 > Viewer > Flatmap Test Replay Screenshots
Dataset 385 > Viewer > Image Test Replay Screenshots
Dataset 226 > Gallery Item Test Replay Screenshots
Dataset 226 > Viewer > Flatmap Test Replay Screenshots
Dataset 226 > Viewer > Segmentation Test Replay Screenshots
Dataset 226 > Viewer > Image Test Replay Screenshots
Dataset 54 > Gallery Item Test Replay Screenshots
Dataset 54 > Viewer > Video Test Replay Screenshots
Dataset 54 > Viewer > Flatmap Test Replay Screenshots
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.

@alan-wu alan-wu merged commit 3bfe602 into nih-sparc:main Nov 21, 2024
6 checks passed
@alan-wu alan-wu deleted the remove-fail-message branch December 5, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddjnw1yu ddjnw1yu ddjnw1yu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan-wu @ddjnw1yu