Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapintegratedvuer. #235

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Update mapintegratedvuer. #235

merged 2 commits into from
Nov 25, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Nov 24, 2024

Update map-viewer to version 1.6.3.

This is a bug-fixes and minor improvements release:

It can be tested here - https://alan-wu-sparc-app.herokuapp.com/

@alan-wu alan-wu requested review from ddjnw1yu and akhuoa November 24, 2024 21:49
Copy link

cypress bot commented Nov 24, 2024

SPARC Vue3 Portal Testing    Run #340

Run Properties:  status check passed Passed #340  •  git commit ee4e17c2a2: Update sql request body sent to flatmap server.
Project SPARC Vue3 Portal Testing
Branch Review mapviewer-1.6.x
Run status status check passed Passed #340
Run duration 15m 39s
Commit git commit ee4e17c2a2: Update sql request body sent to flatmap server.
Committer alan-wu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 25
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 174
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@ddjnw1yu ddjnw1yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ddjnw1yu
Copy link
Collaborator

SPARC Vue3 Portal Testing    Run #337

Run Properties:  <img alt="status check failed" width="10" height="10" src="https://camo.githubusercontent.com/ce191f2ed15e540ea28844862a5b05965953f7fda5ae04d3aa5ec730899a106e/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6661696c65642e737667"> Failed [#337](https://cloud.cypress.io/projects/96rtme/runs/337/overview?utm_source=github&utm_medium=failed&utm_campaign=run%20number)  •  <img alt="git commit" width="10" height="10" src="https://camo.githubusercontent.com/0a4d777bd84d33143a9bd3359a9a5b9817b5b1201ffe6da7c3accaa1a0bc88de/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6769742d636f6d6d69742e737667"> [e7c4d69e2e](https://github.com/nih-sparc/sparc-app-2/commit/e7c4d69e2ed76156c2fcd57c3a28593687d478e2): Update mapintegratedvuer.
Test results
Tests that failed  Failures **18**
Tests that were flaky  Flaky **0**
Tests that did not run due to a developer annotating a test with .skip  Pending **24**
Tests that did not run due to a failure in a mocha hook  Skipped **0**
Tests that passed  Passing **157**
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/datasets/imagegallery.cy.js • 18 failed tests

All image gallery testing failed due to the failed flatmap knowledge/query/ request. Not related to the new changes.

Copy link
Collaborator

@akhuoa akhuoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alan-wu alan-wu merged commit 5224244 into nih-sparc:main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants