Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link in consortia #238

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Dec 12, 2024

Adds links to documentation as described here

@ignapas ignapas added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 12, 2024
@ignapas ignapas requested a review from egauzens December 12, 2024 17:24
@ignapas ignapas self-assigned this Dec 12, 2024
Copy link

cypress bot commented Dec 12, 2024

SPARC Vue3 Portal Testing    Run #363

Run Properties:  status check passed Passed #363  •  git commit 58cae5560f: latest requirements
Project SPARC Vue3 Portal Testing
Branch Review consortia-doc-links
Run status status check passed Passed #363
Run duration 15m 24s
Commit git commit 58cae5560f: latest requirements
Committer Ignacio Pascual
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 25
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 174
View all changes introduced in this branch ↗︎

@ignapas
Copy link
Contributor Author

ignapas commented Dec 13, 2024

@egauzens changes in Contentful need to be published before this works in production. It can be tested locally, though
https://app.contentful.com/spaces/6bya4tyw8399/entries/38ONyngG8Nd1yBVwkYwbM
https://app.contentful.com/spaces/6bya4tyw8399/entries/3JcECbIUEN1qCcDm20o3N8

@egauzens
Copy link
Collaborator

@egauzens changes in Contentful need to be published before this works in production. It can be tested locally, though https://app.contentful.com/spaces/6bya4tyw8399/entries/38ONyngG8Nd1yBVwkYwbM https://app.contentful.com/spaces/6bya4tyw8399/entries/3JcECbIUEN1qCcDm20o3N8

This code will most likely need to be changed/updated. You implemented the wireframes proposed by Dominic, but during CCB they did not vote to use those. Read the latest comments on the ticket. I am trying to decipher what exactly is expected

@ignapas
Copy link
Contributor Author

ignapas commented Dec 24, 2024

@egauzens changes in Contentful need to be published before this works in production. It can be tested locally, though https://app.contentful.com/spaces/6bya4tyw8399/entries/38ONyngG8Nd1yBVwkYwbM https://app.contentful.com/spaces/6bya4tyw8399/entries/3JcECbIUEN1qCcDm20o3N8

This code will most likely need to be changed/updated. You implemented the wireframes proposed by Dominic, but during CCB they did not vote to use those. Read the latest comments on the ticket. I am trying to decipher what exactly is expected

I made the new changes proposed in the Wrike ticket. Happy holidays :)

@egauzens egauzens merged commit 965e25a into nih-sparc:main Jan 3, 2025
6 checks passed
@egauzens egauzens deleted the consortia-doc-links branch January 3, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants