Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dataset cypress testing #774

Merged
merged 25 commits into from
Dec 6, 2023
Merged

Updated dataset cypress testing #774

merged 25 commits into from
Dec 6, 2023

Conversation

ddjnw1yu
Copy link
Collaborator

Description

Adding more dataset-related tests based on SPARC Portal Content QC.
Fixing possible issues to cover more datasets. Issues are recorded in Issues with user testing documents.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tests are run locally using MacOS and Ubuntu systems and the Electron browser. All passed as expected.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@ddjnw1yu ddjnw1yu requested a review from alan-wu November 28, 2023 01:42
@cypress Cypress
Copy link

cypress bot commented Nov 28, 2023 •
edited
Loading

Passing run #19 ↗︎

0 38 1 0 Flakiness 0

Details:

Merge branch 'master' into dataset-testing
Project: SPARC Portal E2E testing Commit: 1ac13fe10f
Status: Passed Duration: 03:57 💡
Started: Dec 1, 2023 3:07 AM Ended: Dec 1, 2023 3:11 AM

Review all test suite changes for PR #774 ↗︎

@ddjnw1yu ddjnw1yu marked this pull request as draft November 28, 2023 02:54
@ddjnw1yu ddjnw1yu marked this pull request as ready for review December 3, 2023 22:57
@ddjnw1yu ddjnw1yu changed the title Dataset cypress testing update Updated dataset cypress testing Dec 5, 2023
alan-wu
alan-wu approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks.

@alan-wu alan-wu merged commit 8ace829 into nih-sparc:master Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-wu alan-wu alan-wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddjnw1yu @alan-wu