Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch algolia default env vars to production #777

Closed

Conversation

Tehsurfer
Copy link
Contributor

Description

If we would like to set the default environment variables to production, in case they are never not set on heroku, this PR is the right place to be

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@@ -484,6 +494,7 @@ export default {

selectedAlgoliaSortOption: function(option) {
this.algoliaIndex = algoliaClient.initIndex(option.algoliaIndexName)
window.algIndex = algoliaClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line here. Thanks.

@alan-wu
Copy link
Contributor

alan-wu commented Dec 5, 2023

This pull request is not necessary, the index and sorting are set using a list of environment variables on the heroku jobs.

@Tehsurfer
Copy link
Contributor Author

Closing this pr as these variables are set on heroku now anyways

@Tehsurfer Tehsurfer closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants