Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user story based testing #779

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

ddjnw1yu
Copy link
Collaborator

@ddjnw1yu ddjnw1yu commented Dec 4, 2023

Description

  1. Adding user stories-based testing.
  • Find segmentation data in the gallery
  • Open scaffold through the gallery
  • Find data by using the categories listed on the homepage
  1. Updated the if statement condition to avoid the error (.length of undefined) in the detail page when the page goes forward/back.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tests are run locally using MacOS/Ubuntu systems and the Electron browser. All passed as expected.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@ddjnw1yu ddjnw1yu requested a review from alan-wu December 4, 2023 23:35
Copy link

cypress bot commented Dec 4, 2023

Passing run #27 ↗︎

0 44 1 0 Flakiness 0

Details:

Merge branch 'master' into user-story-based-testing
Project: SPARC Portal E2E testing Commit: 5963201353
Status: Passed Duration: 06:52 💡
Started: Dec 6, 2023 8:30 PM Ended: Dec 6, 2023 8:37 PM

Review all test suite changes for PR #779 ↗︎

@ddjnw1yu ddjnw1yu marked this pull request as draft December 5, 2023 00:48
@ddjnw1yu ddjnw1yu marked this pull request as ready for review December 5, 2023 22:55
@ddjnw1yu ddjnw1yu changed the title User story based testing Added user story based testing Dec 5, 2023
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alan-wu alan-wu merged commit 84b04a4 into nih-sparc:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants