Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed e2e testing provenance card not showing issue #780

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ddjnw1yu
Copy link
Collaborator

@ddjnw1yu ddjnw1yu commented Dec 5, 2023

Description

Added a recursive function to fix the provenance card not showing issue caused by clicking on the wrong neuron coordinates for e2e testing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Modified test is run locally using the Ubuntu system and the Electron browser. Passed as expected.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@ddjnw1yu ddjnw1yu requested a review from alan-wu December 5, 2023 21:50
Copy link

cypress bot commented Dec 5, 2023

Passing run #25 ↗︎

0 39 1 0 Flakiness 0

Details:

fixed click on wrong neuron coordinate issue
Project: SPARC Portal E2E testing Commit: d16fdd0b3f
Status: Passed Duration: 05:07 💡
Started: Dec 5, 2023 9:53 PM Ended: Dec 5, 2023 9:58 PM

Review all test suite changes for PR #780 ↗︎

Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@alan-wu alan-wu merged commit ec15b89 into nih-sparc:master Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants