Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Biolucida Viewer issue #783

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

egauzens
Copy link
Contributor

Description

Addressed discrepancy some files pennsieve file source package id and biolucida image data source package id

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally via the gallery items in: https://sparc.science/datasets/268?datasetDetailsTab=images

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Dec 11, 2023

1 failed test on run #30 ↗︎

1 49 1 0 Flakiness 0

Details:

Fixed Biolucida Viewer issue
Project: SPARC Portal E2E testing Commit: 4c1a08f130
Status: Failed Duration: 07:16 💡
Started: Dec 11, 2023 9:15 PM Ended: Dec 11, 2023 9:23 PM
Failed  test/cypress/e2e/mapviewer.cy.js • 1 failed test

View Output Video

Test Artifacts
Maps Viewer > Provenance card for Rat Screenshots Video

Review all test suite changes for PR #783 ↗︎

@egauzens
Copy link
Contributor Author

egauzens commented Dec 11, 2023

1 failed test on run #30 ↗︎

1 49 1 0 Flakiness 0
Details:

Fixed Biolucida Viewer issue
Project: SPARC Portal E2E testing Commit: 4c1a08f130
Status: Failed Duration: 07:16 💡
Started: Dec 11, 2023 9:15 PM Ended: Dec 11, 2023 9:23 PM
Failed  test/cypress/e2e/mapviewer.cy.js • 1 failed test

Review all test suite changes for PR #783 ↗︎

This timeout was not introduced by my code changes. It is testing the flatmap viewer: Map Viewer provenance card for map
Timed out retrying after 5050ms: cy.click() could not be issued because this element is currently animating:

...

You can fix this problem by:

Passing {force: true} which disables all error checking
Passing {waitForAnimations: false} which disables waiting on animations
Passing {animationDistanceThreshold: 20} which decreases the sensitivity
https://on.cypress.io/element-is-animating

@egauzens egauzens merged commit 5a3c13e into nih-sparc:master Dec 11, 2023
1 check failed
@egauzens egauzens deleted the fix-biolucida-viewer-bug branch December 11, 2023 21:28
@alan-wu
Copy link
Contributor

alan-wu commented Dec 11, 2023

1 failed test on run #30 ↗︎

1 49 1 0 Flakiness 0
Details:
Fixed Biolucida Viewer issue
Project: SPARC Portal E2E testing Commit: 4c1a08f130
Status: Failed Duration: 07:16 💡
Started: Dec 11, 2023 9:15 PM Ended: Dec 11, 2023 9:23 PM
Failed test/cypress/e2e/mapviewer.cy.js • 1 failed test

Review all test suite changes for PR #783 ↗︎

This timeout was not introduced by my code changes. It is testing the flatmap viewer: Map Viewer provenance card for map Timed out retrying after 5050ms: cy.click() could not be issued because this element is currently animating:
...

You can fix this problem by:

Passing {force: true} which disables all error checking Passing {waitForAnimations: false} which disables waiting on animations Passing {animationDistanceThreshold: 20} which decreases the sensitivity https://on.cypress.io/element-is-animating

We will update the test to either force the click or give it a small timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants