Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update segmentation data to come from sparc-api endpoint #786

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

egauzens
Copy link
Contributor

Description

Updated segmentation viewer to pull its data the same way as before by using the sparc-api endpoint (instead of pulling from the scicrunch['mbf-segmentation'] property

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally using /datasets/file/37/3?path=files%2Fderivative%2Fsub-54-5%2FTJU_3Scan_ratheart54-5_updated_06_11_19_Fiducials.xml

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Dec 12, 2023

Passing run #33 ↗︎

0 50 1 0 Flakiness 0

Details:

added additional check
Project: SPARC Portal E2E testing Commit: e046f95409
Status: Passed Duration: 07:00 💡
Started: Dec 12, 2023 11:47 PM Ended: Dec 12, 2023 11:54 PM

Review all test suite changes for PR #786 ↗︎

@egauzens egauzens merged commit ede6fac into nih-sparc:master Dec 13, 2023
1 check passed
@egauzens egauzens deleted the fix-segmentation-viewer branch December 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants