Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed logic for biolucida data #798

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fixed logic for biolucida data #798

merged 2 commits into from
Feb 22, 2024

Conversation

egauzens
Copy link
Contributor

Description

Logic was incorrectly assuming biolucida2d objects would be defined when biolucida3d objects were present

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally viaq dataset 353

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Feb 22, 2024

Passing run #48 ↗︎

0 47 4 0 Flakiness 0

Details:

condensed logic
Project: SPARC Portal E2E testing Commit: 009629be79
Status: Passed Duration: 08:47 💡
Started: Feb 22, 2024 3:40 PM Ended: Feb 22, 2024 3:49 PM

Review all test suite changes for PR #798 ↗︎

@egauzens egauzens merged commit c99b0c5 into master Feb 22, 2024
2 checks passed
@egauzens egauzens deleted the fix-files-table-error branch February 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants