Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: bumped version and updated dataset details endpoint #805

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

egauzens
Copy link
Contributor

Description

Bumped sparc-design-system version to incorporate a bug fix for categories with singular facets and updated the dataset details to get dataset info solely from the sparc-api endpoints in order to address: https://www.wrike.com/workspace.htm?acc=3203588#/task-view?id=1326363804&pid=416152743&cid=415614298

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@egauzens egauzens requested a review from SamanthaKraft March 19, 2024 22:09
Copy link

cypress bot commented Mar 19, 2024

1 failed test on run #58 ↗︎

1 46 4 0 Flakiness 0

Details:

bumped version and updated dataset details endpoint
Project: SPARC Portal E2E testing Commit: 4762c41bb3
Status: Failed Duration: 08:45 💡
Started: Mar 19, 2024 10:13 PM Ended: Mar 19, 2024 10:22 PM
Failed  test/cypress/e2e/homepage.cy.js • 1 failed test

View Output Video

Test Artifacts
Homepage > Footer Screenshots Video

Review all test suite changes for PR #805 ↗︎

@egauzens egauzens merged commit 9443baf into master Mar 19, 2024
0 of 2 checks passed
@egauzens egauzens deleted the bump-design-system-components-version branch March 19, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants