Merge pull request #99 from nih-sparc/dropdown-multiselect-bug-fix

fixed dropdown multiselect bug
nih-sparc · Mar 8, 2022 · d38df46 · d38df46
2 parents 9e9bb65 + 6d79d16
commit d38df46
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 56 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nih-sparc/sparc-design-system-components",
-  "version": "0.26.9",
+  "version": "0.26.10",
   "private": false,
   "scripts": {
     "serve": "vue-cli-service serve",

diff --git a/src/components/DropdownMultiselect/src/DropdownMultiselect.vue b/src/components/DropdownMultiselect/src/DropdownMultiselect.vue
@@ -177,12 +177,6 @@ export default {
     },
   },
   watch: {
-    allVisibleDataIds(val) {
-      this.$refs.tree.filter(val)
-    },
-    optionsExpanded: function() {
-      this.$refs.tree.filter()
-    },
     'visibleData': function() {
       this.setShowAll();
     }
@@ -194,6 +188,7 @@ export default {
       })
     }
     if (this.showExpandOptionsContainer || this.visibleData !== undefined) {
+      this.numOptionsShown = 0;
       this.$refs.tree.filter()
     }
   },
@@ -274,6 +269,7 @@ export default {
     setOptionsExpanded(isExpanded) {
       this.numOptionsShown = 0;
       this.optionsExpanded = isExpanded
+      this.$refs.tree.filter()
     },
     setShowAll: function() {
       const checkedNodes = this.visibleCheckedNodes

diff --git a/src/stories/dropdownMultiselect/dropdownMultiselect.stories.js b/src/stories/dropdownMultiselect/dropdownMultiselect.stories.js
@@ -58,22 +58,6 @@ export const OneOption = () => createDemo(
   }
 )
 
-export const TwoOptions = () => createDemo(
-  {
-    label: 'Two Options',
-    id: '0',
-    data: [
-    {
-      label: 'One',
-      id: '1',
-    },
-    {
-      label: 'Two',
-      id: '2',
-    }]
-  }
-)
-
 export const NineOptions = () => createDemo(
   {
     label: 'Nine Options',

diff --git a/src/stories/dropdownMultiselect/dropdownMultiselect.stories.mdx b/src/stories/dropdownMultiselect/dropdownMultiselect.stories.mdx
@@ -54,39 +54,7 @@ data() {
 />
 ```
 
-### Less than 5 options Dropdown Multiselect
-
-<Story name="Two Options">{stories.TwoOptions()}</Story>
-
-#### Code
-
-```js
-data() {
-  return {
-    category: {
-      label: 'Two Options',
-      id: '0',
-      data: [
-      {
-        label: 'One',
-        id: '1',
-      },
-      {
-        label: 'Two',
-        id: '2',
-      }]
-    }
-  }
-}
-```
-
-```html
-<dropdown-multiselect
-  :category="category"  
-/>
-```
-
-### Between 5 and 9 options Dropdown Multiselect
+### Between 2 and 9 options Dropdown Multiselect
 
 <Story name="Nine Options">{stories.NineOptions()}</Story>