Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unchecking hidden child facets issue #139

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

egauzens
Copy link
Contributor

@egauzens egauzens commented Mar 6, 2024

Description

Hidden child facets that were being unchecked via the tag container were not firing a check change as described here: ElemeFE/element#11964

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have pushed the final commit message using the changelog format

@egauzens egauzens merged commit dd20249 into main Mar 6, 2024
1 check passed
@egauzens egauzens deleted the fix-reset-all-issue branch March 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant