charts: change helm value enableGarbageCollection to a bool

Signed-off-by: Niladri Halder <[email protected]>
niladrih · Dec 8, 2023 · 16bfef0 · 16bfef0
1 parent 51e31ce
commit 16bfef0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/cmd/provisioner-nfs/main.go b/cmd/provisioner-nfs/main.go
@@ -19,8 +19,9 @@ package main
 import (
 	"os"
 
-	"github.com/openebs/dynamic-nfs-provisioner/cmd/provisioner-nfs/app"
 	logger "github.com/openebs/maya/pkg/logs"
+
+	"github.com/openebs/dynamic-nfs-provisioner/cmd/provisioner-nfs/app"
 )
 
 func main() {

diff --git a/deploy/helm/charts/Chart.yaml b/deploy/helm/charts/Chart.yaml
@@ -4,10 +4,10 @@ description: Helm chart for OpenEBS Dynamic NFS PV. For instructions to install
 type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.10.2
+version: 0.11.0
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
-appVersion: 0.10.0
+appVersion: 0.11.0
 icon: https://raw.githubusercontent.com/cncf/artwork/master/projects/openebs/icon/color/openebs-icon-color.png
 home: http://www.openebs.io/
 keywords:

diff --git a/deploy/helm/charts/templates/deployment.yaml b/deploy/helm/charts/templates/deployment.yaml
@@ -105,9 +105,11 @@ spec:
             {{- end }}
             # Provide a switch to turn off the function of clearing stale pvc to avoid
             # garbage collecting an NFS backend PVC if the NFS PVC is deleted.
+            {{- if .Values.nfsProvisioner.enableGarbageCollection }}
             - name: OPENEBS_IO_NFS_SERVER_GARBAGE_COLLECTION_ENABLED
-              value: "{{ .Values.nfsProvisioner.enableGarbageCollection }}"
-           {{- if .Values.nfsProvisioner.nfsBackendPvcTimeout }}
+              value: {{ quote .Values.nfsProvisioner.enableGarbageCollection }}
+            {{- end }}
+            {{- if .Values.nfsProvisioner.nfsBackendPvcTimeout }}
             - name: OPENEBS_IO_NFS_SERVER_BACKEND_PVC_TIMEOUT
               value: "{{ .Values.nfsProvisioner.nfsBackendPvcTimeout }}"
             {{- end }}

diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml
@@ -42,7 +42,7 @@ nfsProvisioner:
   enableLeaderElection: "true"
   # Provide a switch to turn off the function of clearing stale pvc to avoid
   # garbage collecting an NFS backend PVC if the NFS PVC is deleted.
-  enableGarbageCollection: "true"
+  enableGarbageCollection: true
   # Specify image name of nfs-server-alpine used for creating nfs server deployment
   # If not mentioned, default value openebs/nfs-server-alpine:tag will be used where
   # the tag will be the same as a provisioner-nfs image tag
@@ -116,7 +116,7 @@ nfsStorageClass:
   # for the NFS server's shared filesystem volume.
   # File permission changes are applied recursively if the root of the
   # volume's filesystem does not match the specified value.
-  # For more information: https://github.com/openebs/dynamic-nfs-provisioner/blob/develop/docs/tutorial/file-permissions.md
+  # For more info: https://github.com/openebs/dynamic-nfs-provisioner/blob/develop/docs/tutorial/file-permissions.md
   filePermissions: {}
   # The UID value is used to set the user-owner of NFS shared directory. Only valid
   # UIDs are accepted.