Fix incorrect inheritance penalty for some objects (#24144)

This fixes a logic error in #23870 The inheritance penalty should be -1 if there is no inheritance relationship. Not sure how to write a test case for this one honestly. --------- Co-authored-by: Andreas Rumpf <[email protected]>
nim-lang · Sep 20, 2024 · 37dba85 · 37dba85
1 parent 755307b
commit 37dba85
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/compiler/sigmatch.nim b/compiler/sigmatch.nim
@@ -1540,7 +1540,7 @@ proc typeRel(c: var TCandidate, f, aOrig: PType,
         reduceToBase(a)
     if effectiveArgType.kind == tyObject:
       if sameObjectTypes(f, effectiveArgType):
-        c.inheritancePenalty = 0
+        c.inheritancePenalty = if tfFinal in f.flags: -1 else: 0
         result = isEqual
         # elif tfHasMeta in f.flags: result = recordRel(c, f, a)
       elif trIsOutParam notin flags: