close #11330 sets uses optimized countSetBits #17334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Mar 11, 2021
timotheecour
changed the title
timotheecour
approved these changes
Mar 20, 2021
timotheecour
approved these changes
Mar 21, 2021
Araq
reviewed
Mar 21, 2021
Araq
reviewed
Mar 21, 2021
ringabout
commented
Mar 21, 2021
ringabout
commented
Mar 21, 2021
ringabout
commented
Mar 21, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* Update lib/pure/bitops.nim * Update lib/system/sets.nim * Apply suggestions from code review Co-authored-by: Andreas Rumpf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11330
followup
now that sets is an import module, move it to lib/std/private/sets_builtin
close #11330 sets uses optimized countSetBits #17334 (comment)
ditto for countbits_impl