Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jshttpclient #17373
Add jshttpclient #17373
Changes from 21 commits
2ffffaa
4996be6
3b51e02
07773b9
ad901fc
7d8ddcf
ebd885b
3b6c838
72a5a19
776d73c
3e67862
dc1866b
b53c403
673d4f3
1c5b97a
c45deae
37059c6
c908664
05990b4
ae2ae76
86534fa
700a826
0a0c6fe
8e3a720
46783d7
a7064e3
a2f4ffc
e2d48a9
437583c
2ebfee5
90292a4
691a320
81dfeee
bf0c2ce
7fb5957
1cf2696
daf311c
e17b274
ad7e60f
f64e467
9b4d6e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this example doesn't work in a browser
I have a WIP PR to make
nim doc -b:js -r --browser main
which will simplify testing but until it's merged, these things must be tested manuallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this API is completely new, should we only allow
Uri
and notstring
?.