-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #17853 (ascii message separator broke json nim dump) #17887
fix #17853 (ascii message separator broke json nim dump) #17887
Conversation
3c38c24
to
b7fade4
Compare
|
||
var ps: seq[Process] # compile & run 2 progs in parallel | ||
const nim = getCurrentCompilerExe() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous code was using "nim", which didn't honor testament --nim:/pathto/nim r test
I prefer to simply fix |
b7fade4
to
c5b47c0
Compare
c5b47c0
to
18e78c6
Compare
done (but I can't help but remember the similar issues that dot processing caused) |
see also #18162 which ended up doing |
nim dump --dump.format:json
)nim dump --dump.format:json
**keep binary compatible**
notice forTGlobalOption
\31
in unit separator #17730 are now reverted backtestament --nim:/pathto/nim r test
CI failure unrelated (classic flaky #17325)