Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #18011 disable some newly failing tests on cpp windows; refs #17946 increase timeout for tchannels #18012

Merged

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented May 14, 2021

refs #18011

(innocuous change to see if i can reproduce #18011 before disabling failing tests)
EDIT: indeed, I can

CI failures:

2021-05-14T20:20:29.9353041Z FAIL: tests/stdlib/tchannels.nim c (21.81 sec)

@timotheecour timotheecour changed the title refs #18011 refs #18011 disable some newly failing tests on cpp windows; refs #17946 increase timeout for tchannels May 14, 2021
@timotheecour timotheecour marked this pull request as ready for review May 14, 2021 22:31
@timotheecour
Copy link
Member Author

@Araq I'm merging this because #18011 affects all recently rebased PR's, the bug is kept open as the tests were disabled, not fixed (can't really debug the problem as I'm not on windows)

as you can see with 1st commit, the bug triggers for un-related reason; the next commits then disable the newly failing tests

@timotheecour timotheecour merged commit 2ce592a into nim-lang:devel May 14, 2021
@timotheecour timotheecour deleted the pr_refs_18011_windows_cpp_disable branch May 14, 2021 22:33
narimiran pushed a commit that referenced this pull request May 17, 2021
 increase timeout for tchannels (#18012)

(cherry picked from commit 2ce592a)
narimiran pushed a commit that referenced this pull request Nov 9, 2021
 increase timeout for tchannels (#18012)

(cherry picked from commit 2ce592a)
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant