fix #18007: std/json now serializes nan,inf,-inf as strings instead of invalid json #18026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs instead of invalid json
timotheecour
changed the title
timotheecour
added
the
Ready For Review
ringabout
reviewed
May 16, 2021
ringabout
approved these changes
May 16, 2021
Araq
reviewed
May 16, 2021
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
…nstead of invalid json (nim-lang#18026) * fix nim-lang#18007: std/json now serializes nan,inf,-inf as raw strings instead of invalid json * fix roundtrip * fix tests * fix changelog * simplify * add runnableExamples * fix typo [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18007
closes #18020
i could add a
-d:nimLegacyJsonNaNInfif needed, but doesn't seem like it's needed in this case because the json that was previously generated was invalidthe serialization/deserialization is now rountrip safe and uses valid json
note
testRoundtripValare from #18008 but since that PR wasn't merged yet and I needed those test procs, I've added those here