added float32 schubfach algorithm; wip #18155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
reviewed
Jun 2, 2021
| @@ -0,0 +1,451 @@ | |||
| ## Copyright 2020 Alexander Bolz | |||
There was a problem hiding this comment.
as i was doing in #18008, can you add a readme.md somewhere (maybe lib/vendor/readme.md in which we can add future external dependencies under lib/vendor) to show:
- the git repo involved, the files that were copied, and the hash at which the repo was cloned
- the c2nim command used (i'm assuming smthg like
c2nim --cpp --keepBodies -o:lib/system/schubfach.nim $Drachennest/src/schubfach_32.cc) - ideally, split in 2 commits, 1 with raw c2nim output (maybe marked
[wip]so git bisect can learn to skip it), and one with the manual modifications, that way it's more reproducible/transparent and easier to update from upstream if needed
There was a problem hiding this comment.
Good ideas, will do it maybe later. But I consider remaining bugs to be our own, not related to dragonbox/schubfach, just like we avoided certain TLSF bugs by porting over to Nim.
There was a problem hiding this comment.
i was referring to not just bugs but performance improvements, not that they can't be ported over again
Good ideas, will do it maybe later.
=> 282d61b
timotheecour
reviewed
Jun 2, 2021
| not defined(js) and defined(nimHasDragonBox): | ||
| import schubfach | ||
|
|
||
| proc nimFloat32ToStr(f: float32): string {.compilerproc.} = |
There was a problem hiding this comment.
how about adding float32 overloads for addFloat, $, writeFloatToBuffer
timotheecour
added
the
TODO: followup needed
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* added float32 schubfach algorithm; wip * fixes nim-lang#18418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.