-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
float parsing: Add test for a fixed issue #18232
Conversation
@Araq I see that the order of the Hints got shuffled up when I added that let block at the end. Is that shuffling expected? For that reason, the diff of the discard block is bigger than I expected. I expected only line number changes in there. But instead, I also had to paste the exact order of Hints that I saw when compiling that test locally. |
The order of the Hints messages is still an issue. The changes in this test passed on most machines, but failed on:
|
please open a separate issue to track that (and cross-link there); it's fixable using perhaps similar approach as I did in #13701 for sorting sigmatch errors in the meantime you can use a different file for the test case as a workaround |
Ok, I'll do that later today. Thanks. |
76ca2fd
to
915be25
Compare
or wait for #18336 to get merged, that way we don't have to add another file here |
@timotheecour Looks like waiting for your PR merge is the only option 😃
|
ping now that #18336 was merged |
Fixes nim-lang#14407 . This issue was fixed by nim-lang#18139.
915be25
to
3a6b7f2
Compare
@timotheecour PTAL This PR now passes the CI. |
Fixes nim-lang#14407 . This issue was fixed by nim-lang#18139.
Fixes #14407 .
This issue was fixed by #18139.
This command passes on my machine: