Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #20285; prevent oid time overflow at year 2038 #20338

Merged
merged 7 commits into from
Sep 22, 2022
Merged

fixes #20285; prevent oid time overflow at year 2038 #20338

merged 7 commits into from
Sep 22, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Sep 12, 2022 •
edited
Loading

@ringabout
Copy link
Member Author

I reproduce the issue by setting the date on my computer to year 2038.

@Varriount
Copy link
Contributor

Is it possible to add a test for this?

@ringabout
Copy link
Member Author

I guess not too easy, at least we probably can get one at openSUSE :)

@ringabout ringabout mentioned this pull request Sep 15, 2022
Closed
Varriount
Varriount reviewed Sep 15, 2022
View reviewed changes
@metagn
Copy link
Collaborator

metagn commented Sep 17, 2022 •
edited
Loading

Can we use the date command to test it?

edit: lol, the last commit says it was made on Sep 12, 2038

@Varriount
Copy link
Contributor

I'm ok with either:

  • Matching whatever behavior MongoDB exhibits (as long as the behavior isn't "raise an exception")
  • Increasing the underlying integer size to 64 bits.

@Araq
Copy link
Member

Araq commented Sep 21, 2022

I say, please increase the underlying integer size to 64 bits.

@ringabout
Copy link
Member Author

Sure

@ringabout
Copy link
Member Author

Once again, I set the system date to 2038 and there is no problem.

@Araq Araq added the merge_when_passes_CI mergeable once green label Sep 22, 2022
@ringabout ringabout merged commit db8a62d into devel Sep 22, 2022
@ringabout ringabout deleted the pr_int32 branch September 22, 2022 13:15
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from db8a62d

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164054 lines; 12.595s; 842.328MiB peakmem

metagn
metagn reviewed Sep 22, 2022
View reviewed changes
ringabout added a commit that referenced this pull request Sep 22, 2022
@ringabout
Revert "fixes #20285; prevent oid time overflow at year 2038 (#20338)"
2843f27 
This reverts commit db8a62d.
@ringabout ringabout mentioned this pull request Sep 22, 2022
Closed
@ringabout ringabout mentioned this pull request Oct 11, 2022
Merged
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nim-lang#20285; prevent oid time overflow at year 2038 (nim-lan…
47eb140 
…g#20338)

* Revert "fixes  nim-lang#20285; prevent oid time overflow at year 2038"

This reverts commit dfcdb6e.

* increase time to 64 bits and clean up

* add testcase

* inline consts

* add a changelog

* fixes  nim-lang#20285; prevent oid time overflow at year 2038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

@Varriount Varriount Varriount left review comments

@metagn metagn metagn left review comments

Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail in 2038
4 participants
@ringabout @Varriount @metagn @Araq