fixes inefficient codegen for field return #24874
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Apr 29, 2025
| @@ -1205,7 +1224,11 @@ proc moveOrCopy(dest, ri: PNode; c: var Con; s: var Scope, flags: set[MoveOrCopy | |||
| of nkRaiseStmt: | |||
| result = pRaiseStmt(ri, c, s) | |||
| else: | |||
| if isAnalysableFieldAccess(ri, c.owner) and isLastRead(ri, c, s) and | |||
| let isOwnsData = ownsData(c, s, ri2, flags) | |||
There was a problem hiding this comment.
Arbitrary logic. Shouldn't isAnalysableFieldAccess etc be able to handle this? I think there is a real bug to be fixed here somewhere, not more custom logic to be added.
There was a problem hiding this comment.
Isn't isAnalysableFieldAccess, isLastRead etc. analysis based on nkSym? What's the rule that it should handle callkinds in f().s? Should I treat the callkinds as the last read?
On the other hand, the # Rule 3: =sink(x, z); wasMoved(z) branch is not correct for f().s, because f() may have side effects. We need to create a temp for f() and clean up the potential memory of f()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23395
fixes #23395