Disable strict aliasing on clang #25067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for nim-lang#24596. I also took the liberty to disable it on all targets with GCC, since their documentation claims that it is also enabled on -Os.
bptato
added a commit
to bptato/Nim
that referenced
this pull request
Jul 23, 2025
Alternative to nim-lang#25067; fixes nim-lang#24596. Pros: * No codegen changes needed. * No negative changes in generated code size. * Works with all standard-conforming C compilers - conceptually, memcpy treats both structs as character types, which are compatible with all types. Cons: it's very ugly.
|
CI fails with some super weird changes in the stack tracing. No idea, ping @ringabout |
|
I think it marks a real issue of the change, though I have no clue for now |
|
It seems that some C warnings disturbing the output comparing of testament, which causes CI to fail. I guess warnings are needed to be suppressed somehow |
|
Oh, I think I've found the issue... let's see |
|
@Araq seems to be working now |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #24596.
I also took the liberty to disable it on all targets with GCC, since their documentation claims that it is also enabled on -Os.