Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion errors #1352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bash completion errors #1352

wants to merge 1 commit into from

Conversation

micl2e2
Copy link
Contributor

@micl2e2 micl2e2 commented Feb 28, 2025

When being used in conjunction with nim's completion scripts in such style:

source /path/to/nim.bash-completion
source /path/to/nimble.bash-completion

, and there would be an error while completing nim:

<TAB>
bash: ilastlast: substring expression < 0

nim's completion fails because both share the same helper functions: __is_short_or_long, __ask_for_subcmd_or_subopts, __ask_for_subcmd, __ask_for_subcmd_opts, and the impl of nimble's ones are a little bit more outdated than nim's ones, and multiple sources will overide the previous definition. This pr simply reuses those functions in nim, nimgrep, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant