Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new channels article #274
new channels article #274
Changes from 4 commits
b7e0d06
4a5901e
f28cebd
4bb8b90
4183f52
5b87806
8b43a3b
5f11cf4
8db9837
a381873
5f11660
4b45bcd
426ce67
f9e5f94
42513d9
c124ead
9d6db08
01c6bf0
965e392
fe2b67e
accb697
84c5b0e
ef79a5d
d2383bd
df83246
40b3d70
52f3a07
5c9b9ec
44abd9a
0d6700a
bc1bbb6
3d1169d
1aa803f
f2a595e
fefc4eb
2f9ed9a
c112607
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about making this test self-contained by using a string instead of a file:
and adapting
prepareTasks
.furthermore, I'd recommended making it even simpler by making 1 task = 1 url:
(since the added complexity has nothing to do with std/channels). Simpler examples are easier to adapt to new settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see nim-lang/Nim#17405