Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move path filtering to a CI job instead #238

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

alaviss
Copy link
Contributor

@alaviss alaviss commented Sep 16, 2021

Github's brilliant path filtering system is incompatible with
it's required checks system, so as a workaround we move to an userspace
version which won't have this issue.

A new 'All check passes' job is added to match against in required
checks since the feature doesn't work if the matrix isn't evaluated (ie.
when its skipped).

Tested with a mock PR which worked: alaviss#5

Will require adjustment of the required checks constraints to All check passes since the matrix won't evaluate if the job is skipped and Github won't see the required macos-latest check...

Github's brilliant path filtering system is incompatible with
it's required checks system, so as a workaround we move to an userspace
version which won't have this issue.

A new 'All check passes' job is added to match against in required
checks since the feature doesn't work if the matrix isn't evaluated (ie.
when its skipped).
@alaviss alaviss requested a review from disruptek September 16, 2021 17:15
@disruptek disruptek added the workaround like a walkaround, but, sensical label Sep 16, 2021
@disruptek disruptek merged commit 7394f18 into nim-works:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workaround like a walkaround, but, sensical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants