move path filtering to a CI job instead #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github's brilliant path filtering system is incompatible with
it's required checks system, so as a workaround we move to an userspace
version which won't have this issue.
A new 'All check passes' job is added to match against in required
checks since the feature doesn't work if the matrix isn't evaluated (ie.
when its skipped).
Tested with a mock PR which worked: alaviss#5
Will require adjustment of the required checks constraints to
All check passes
since the matrix won't evaluate if the job is skipped and Github won't see the requiredmacos-latest
check...